User "Hashar" posted a comment on MediaWiki.r96188. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96188#c24766 Commit summary:
Expand r96170's support for space separated attributes with support for boolean keys such as array( 'class' => array( 'selected' => true ) ) to match our array( 'checked' => false ) support. As per discussion with Krinkle make sure that in array( 'foo', 'foo' => false, 'foo' ) the 'foo' key is authoritive. Comment: The commit message is not very clear to me: array( 'foo', 'foo' => false, 'foo' ) the 'foo' key is authoritative I am assuming the => false will override the key hence in this case there will be no 'foo'. Can you confirm this is the expected behavior? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
