User "Catrope" posted a comment on MediaWiki.r100025.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100025#c24772
Commit summary:
Adjustments to r99351 r99350 r99200 per code review:
* Replace the "show" link with a spinner, and add error handling.
* Use data() instead of attr() where appropriate.
* Fix an errant removal of parameters.
* Fix double-escaping
Comment:
<pre>
+ if ( data && data.query &&
data.query.moodbarcomments ) {
</pre>
You also need to check that <code>data.query.moodbarcomments.length > 0</code>
before accessing <code>data.query.moodbarcomments[0]</code> .
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
