User "Awjrichards" changed the status of MediaWiki.r100644. Old Status: new New Status: ok
User "Awjrichards" also posted a comment on MediaWiki.r100644. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100644#c24793 Commit summary: Moves the language defaulting process to DonationData's normalizeAndSanitize function: Now, if nothing is sent explicitly in the forms, it will pull the code from the current global language object, on construct. Comment: It looks like we still honor language= or uselang= from the query string, which is good - we only want to fall back on $wgLang->getCode() if we're otherwise clueless. Unless I'm mistaken about that, this looks fine! _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
