User "Jeroen De Dauw" posted a comment on MediaWiki.r99619. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99619#c24800 Commit summary:
Follow up to r99618; matching fix made in contest extension Comment: > It's also possible to do this: create a new campaign with the name "foo", > then edit the campaign name to be an already existing campaign, then press > save, and it overwrites the existing campaign. This seems surprising IMO. This does not happen, because then the ID will be set. This makes the ID field not redundant. I get the impression you made some wrong assumption(s) about the code, which does indicate it's not very clear. I agree that having 2 identifiers is less clear then having one, and that this is not made any better by the fact that you can change the name. One thing you could do is simply make the name non-changeable, making the code in question obsolete. In any case, feel free to change this; I just think the code you initially suggested is not better, and that the current code is, although it's not obvious, also not bad, and does not have any real impact on the functionality anyway. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
