User "Khorn (WMF)" posted a comment on MediaWiki.r100648. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100648#c24842 Commit summary:
Fixed the issues with credit cards for r100643. Comment: The iframe on the second page, which is hosted by GlobalCollect, collects card number, expiration date, and cvv. Another way to look at this is: We should only be validating the fields we're sending over to them, as defined in the specific transaction we're doing. For this reason (ease of lookup), I wonder if we don't want to just add the sections that need to be validated, to the transaction definition itself. That way, it's all in one place, and you don't have to bounce around so much cross-referencing definitions. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
