User "Brion VIBBER" changed the status of MediaWiki.r82471. Old Status: ok New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r82471. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82471#c24862 Commit summary: Improving jquery.makeCollapsible & small fixed mw.util * Making makeCollapsible more DRY. * Small optimalizations and fixes in mw.util Comment: It looks like while it is doing a quickish hide at initialization time, it's still starting a fade-out animation afterwards (via the .click()) -- this could be causing the slowdowns described at bug 31945. The previous note above about content still being shown uncollapsed for a bit before being hidden also matches what I see -- the initial state is visible until the initialize code gets run, hiding things. This means stuff will be visible expanded while the page is loading, if it takes long enough to load everything. This can be (semi) solved by setting the style for the initially-collapsed class to make sure they're always hidden to begin with... however that's sub-ideal for non-JavaScript cases, where we need them to show initially visible. May need to resolve that. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
