User "G.Hagedorn" posted a comment on MediaWiki.r100806. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100806#c24907 Commit summary:
Make ArticleFeedback actually support custom rating types properly. This is getting to the point where it's hacks on top of hacks, would be nice to redesign it properly some time. * Move config.ratings in JS to $wgArticleFeedbackRatingTypes in PHP. This supersedes $wgArticleFeedbackRatings, which I removed. * Derive the -label and -tip message keys from the rating type name. The -tooltip-$i message keys are derived this way already * Take out the hardcoded message keys for the default rating types, and put the rating i18n in a separate module whose message keys are populated dynamically based on the config * Kill the article_feedback_ratings table with fire, all the needed data is in $wgArticleFeedbackRatings * Fix the numbering of the hidden inputs, was assuming rating ID numbering started at 1 * Add a WHERE clause for afr_rating_id to ApiQueryArticleFeedback to prevent weirdness in the midst of a rating type migration * Generally change things to comply with these changes Comment: applied to 1.18wmf1, please consider tagging for 1.18 _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
