User "Awjrichards" changed the status of MediaWiki.r100896. Old Status: new New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100896 Commit summary: Mostly concerned with splitting currentTransaction into getCurrentTransaction and setCurrentTransaction, in the main gateway adapter parent class. Lots of function comments. Additional: Many functions that are never ever ever ever ever supposed to be accessed from the outside of an adapter, are now protected. The ones that are absolutely supposed to be used form the outside are now explicitly public. Those that are just functions have not yet been evaluated during the cleanup process. This should help immensely with what is turning out to be a rather large and unwieldy class. If you absolutely must access protected functions directly, I don't believe you. (...unless you're doing unit tests, in which case you should have a dummy adapter child class anyway, and that can give you direct pass-through access to whatever you feel you need.) r95923 _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
