User "Khorn (WMF)" changed the status of MediaWiki.r100460. Old Status: new New Status: deferred
User "Khorn (WMF)" also posted a comment on MediaWiki.r100460. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100460#c24940 Commit summary: Changed $transaction_groups to $payment_methods. Changed $transaction_types to $payment_submethods. Added get methods for access to payment_methods and payment_submethods. Comment: A couple things would make this a fixme, but they're both gone by now. (getValue going public when it should be internal use only, using 'INSERT_ORDERWITHPAYMENT' in the abstract class) Only one comment: If we intend to implement definePaymentMethods and definePaymentSubMethods for all adapters, they should both be in the interface, and get called initially in the main gateway.adapter's constructor so all the gateways remain consistent. As this isn't an issue right now (and would definitely cause more problems than it would solve), I'm just going to leave this note here and call it "deferred". _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
