User "Khorn (WMF)" changed the status of MediaWiki.r100622. Old Status: new New Status: fixme
User "Khorn (WMF)" also posted a comment on MediaWiki.r100622. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100622#c24950 Commit summary: Made currentTransaction() public for unit testing. Added getDonationData() for unit testing. Comment: Actually, I'd _really_ prefer if we don't make the innards available to the public in this way. It's far too confusing for other developers who want to easily use adapters and know what they should be accessing from the outside... not to mention the part where making everything publicly accessible opens up the door for a large number of vectors for abuse. If you want access to private or protected members in a unit test, create an object that extends the object you want to test, which only contains some methods which can safely pass the internal functions and objects to your tests, and vice versa. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
