User "Catrope" posted a comment on MediaWiki.r100890.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100890#c24973
Commit summary:
[RL2] Make the shared gadgets tab on the preferences page work. This changes
lots of things.
* Kill the hack in r100853 completely
* Instead, always populate the 'options' field of the preferences section with
the IDs of foreign gadgets retrieved from the GadgetRepo classes
* For the description of the gadget, put in the ID as a dummy and have JS fill
it out on load
* Rename the gadgets-shared preferences section to gadgetsshared to prevent
namespacing conflicts
* Slap a CSS class on the gadgetsshared section from PHP, and use CSS to hide
the checkboxes until JS has had a chance to fix the labels up. TODO: probably
needs a spinner
* TODO: This is still using dummy data, we still need to pull the data using
AJAX and figure out the category-ID-conflict-across-repos issue. I'll work on
that tomorrow
Comment:
You mean something like this?
<pre> // TODO: This structure allows cross-pollination of categories when
multiple foreign repos are involved, do we want that?
// I guess probably not, because we wouldn't even know where to pull
the category message from to begin with.
// Probably needs an extra level for the repo.</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
