User "Petrb" posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24982 Commit summary:
user configuration fixed db Comment: I don't see a reason to do join, anyway, user object may return correct name, but there are other ways used than that, for instance oldUsername etc. are you sure that all of those variables return correct capitalisation? everywhere? it's same risk as if you create a function which doesn't handle potentialy unset variable just because "you are sure" this variable is always set... _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
