User "Khorn (WMF)" posted a comment on MediaWiki.r100942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100942#c25009 Commit summary:
Added GlobalCollectTestAdapter for testing the GlobalCollect adapter. Comment: I am totally going to argue with you on this one, particularly if there's any chance that this code could get fired automatically on a commit trigger. If you need to get a response back from them for a test to go through, you're testing their servers more than you're unit testing our internal code, which technically speaking is no longer unit testing. Additionally: It could be catastrophic if somebody somewhere installs this code and misses a setting, or makes one bad commit. Then suddenly we're talking international wire fraud. Yes: This is actually that dangerous. Not just for us, but for others who might install the code and fire it off. It would be infinitely better for all possible involved parties if they actually had to deliberately damage something to get into trouble. Us as well. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
