User "Catrope" posted a comment on MediaWiki.r99840.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99840#c25084
Commit summary:

Followup to r99653 (bug 31643) -- reenable client-side thumbnailing of SVGs on 
Special:Upload, with workaround for Firefox 7 regression.

Upstream firefox bug for hang loading some SVGs via data URI: 
https://bugzilla.mozilla.org/show_bug.cgi?id=694165
A fix may land as soon as Firefox 8.

This rev works around the bug by using window.URL.createObjectURL() instead of 
loading a data URI via FileReader; the object URL loads more cleanly and 
doesn't have the same hanging bug.

Needs to be replicated to UploadWizard (or moved to a shared lib!), some other 
fixes coming so no rush.

Comment:

<pre>
+        * @todo put SVG back after working around Firefox 7 bug 
<https://bugzilla.wikimedia.org/show_bug.cgi?id=31643>
</pre>
Was added in r99653, should be removed here then.

<pre>
+                       // todo: 
</pre>
?!?

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to