User "Catrope" changed the status of MediaWiki.r101190. Old Status: new New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101190 Commit summary: 1.18wmf1 hack: make all URLs to CR revisions in CR e-mails https. Ugly hack discussed with Roan: [8:09p] siebrand: Any objections against this live hack in 1.18wmf1 code review for CR mails? [8:09p] siebrand: CodeRevision.php, line 448: $rowUrl = $revision->getCanonicalUrl(); [8:09p] siebrand: // Live hack: always make the URL use https: [8:09p] siebrand: $rowUrl = str_replace( 'http:', 'https:', $rowUrl ); [8:10p] RoanKattouw: Eww [8:10p] siebrand: it's not getting fixed, and I am getting seriously annoyed by it; couldn't find a more elegant solution... [8:17p] siebrand: RoanKattouw: what's the better fix? [8:17p] siebrand: RoanKattouw: (that's not going to take weeks until someone has time to do the rework) [8:17p] RoanKattouw: The live hack will be fine then _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
