User "Aaron Schulz" posted a comment on MediaWiki.r100211. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100211#c25132 Commit summary:
* Removed newFileFromKey() which had a misleading description and a bug where giving a sha1,time could fail if two current version files existed with the same sha1 but different timestamps. Merged the code into findFileFromKey(). * Fixed bug in findFileFromKey() were it would bail out if it couldn't find a matching current file without even check for matching old files. * Fixed timestamp format of oi_timestamp condition in newFromKey(). * Some code style cleanups. Comment: Also, newFileFromKey() had no outside callers. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
