User "Catrope" changed the status of MediaWiki.r100927.

Old Status: ok
New Status: fixme

User "Catrope" also posted a comment on MediaWiki.r100927.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100927#c25144
Commit summary:

Followup r100905, cleanup per CR and fixes the overriding of the main 
RequestContext

Comment:

<pre>
+               if ( isset( $request ) ) {
+                       $context->setRequest( $request );
+               }
</pre>
As MaxSem points out on r100905 CR this is still wrong. You need to call 
setRequest() on $this->getContext() (the derivative context you created) not on 
$context (the original global context).

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to