User "Afeldman" changed the status of MediaWiki.r100788. Old Status: new New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100788 Commit summary: * Moved the multicast join function out of the generic Socket class and into UDPSocket where it belongs, renamed it to JoinMulticast. Have it accept an IPAddress instead of char* per convention. * Rewrote JoinMulticast, implemented IPv6 multicast group join support. * Fixed the non-functional char* constructor of IPAddress. * Added a constructor from std::string to IPAddress, for convenience. * Added some IPAddress wrappers for INADDR_ANY and in6addr_any. * Sprinkled in some const modifiers. * Enforced the non-copyable nature of Socket with a private constructor. * Enforced the fact that Socket is a pure base class and should not be instantiated, by making all constructors private or protected. * In udp2log, fixed the ridiculous attempt at polymorphic object construction introduced in r75452, mimicked in r95725. * Moved -lboost_program_options to the end of the object list, the linker now seems to want this. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
