User "Reedy" posted a comment on MediaWiki.r101449.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101449#c25250
Commit summary:

Bug 30934 - Warning: Invalid argument supplied for foreach() in 
/languages/Language.php on line 423

Doing a run of doRebuildLocalisationCache on each run of update.php

Comment:

It's only setting it for the time that update.php runs.

<pre>
                $force = $this->hasOption( 'force' );
//SNIP
                $conf = $wgLocalisationCacheConf;
                $conf['manualRecache'] = false; // Allow fallbacks to create 
CDB files
                if ( $force ) {
                        $conf['forceRecache'] = true;
                }
                $lc = new LocalisationCache_BulkLoad( $conf );
</pre>

There is currently no functional way to pass --force dynamically to a 
maintenance script, so this was the simplest workaround. Though, I notice that 
beneath it, $force is also used in other places

I don't really want to be getting to the extent of shelling out to do a call to 
run the maintenance script

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to