User "Catrope" changed the status of MediaWiki.r101488. Old Status: fixme New Status: new
User "Catrope" also posted a comment on MediaWiki.r101488. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101488#c25275 Commit summary: Cache the result of User::getDefaultOptions(), so the UserGetDefaultOptions hook (introduced in r97365) is run only once rather than on every call. Discovered this issue after seeing an insane number of memcached fetches in my RL2 code, caused by a UserGetDefaultOptions hook accessing the Gadgets storage backend (which has a memc layer) and being called a zillion times due to this bug. Comment: It seems I broke the way parser tests change the user language. Four tests are now broken and all the diffs have English texts instead of Catalan or Turkish or whichever language is being tested by that test. http://integration.mediawiki.org/ci/job/MediaWiki-phpunit/1114/ _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
