User "Brion VIBBER" changed the status of MediaWiki.r74966. Old Status: resolved New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r74966. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/74966#c25282 Commit summary: First shot at porting Monobook to Vector. The only non-straightforward part is moving from a separate rtl.css file to a main.css file we can safely Janus. This is half-done right now. Notable things: * No longer including rtl.css, instead relying on Janused main.css * Renamed external.png to external-ltr.png so Janus will pick up on external-rtl.png (already exists) * Added @embed to all images, add @noflip where needed (may not have covered all cases) * Pulled some things from rtl.css into main.css such that they're no-ops in LTR but are needed in RTL. Example: body { direction:ltr; * Killed some RTL-specific rules in main.css that were superseded in main.css * Changed padding: 0 foo; to padding-right: foo; so it gets Janused right * Commented out loading of IE*Fixes.css. Still need to incorporate these into main.css somehow Comment: All it appears to do is add a lot of spacing in IE 7 and IE 8/9 in IE 7 compatibility mode: bug 31993 If there's no other reason for it, I say we kill it. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
