User "Brion VIBBER" posted a comment on MediaWiki.r101244. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101244#c25308 Commit summary:
Remove more assignments in conditionals (while each to foreach) Comment: There's a next() call inside the look in parseMatch. [http://us2.php.net/manual/en/control-structures.foreach.php PHP docs] warn against relying on the array pointer value during or after foreach() so this may or may not be undefined behavior... in theory foreach operates on a copy of the array unless you explicitly referenced it, so i'm not sure it would actually be advancing the pointer on the original....? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
