User "Awjrichards" changed the status of MediaWiki.r101576. Old Status: new New Status: fixme
User "Awjrichards" also posted a comment on MediaWiki.r101576. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101576#c25317 Commit summary: begining to handle transaction errors for globalcollect - this might be all wrong! Comment: Out of curiosity: <pre> $data = $this->adapter->getData(); + $referrer = $data['referrer']; + unset( $data['referrer'] ); + $data['amount'] = $data['amount']/100; + $data['error'] = $declinedDefault; + + $params = wfArrayToCGI( $data ); + $returnto = htmlspecialchars_decode( $referrer ) . '&' . $params; + return $returnto; </pre> Why not: <pre> $data = $this->adapter->getData(); $data['referrer'] = htmlspecialchars_decode( $referrer ); $data['amount'] = $data['amount']/100; $data['error'] = $declinedDefault; return wfArrayToCGI( $data ); </pre> Also (either way) - this just returns a query string. Is this expected? Does $wgOut->redirect() handle just a query string in the way you're expecting it to here? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
