User "Khorn (WMF)" posted a comment on MediaWiki.r101502. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101502#c25341 Commit summary:
Actually fixes the api calls that handle gateway forms with _cache_ set to true, and a utm_source_id set. r101441 Comment: Actually, the reason for both of these things is the same tricky thing that messed me up for way too long. When we're coming in through the API, we don't have a form post, so none of the code that defaults the values on a form post pull gets run. I construct the DonationData object with only the values that the API passes back to me (api_payflowpro_gateway.php, line 157). It's faster, but it short-circuits a heck of a lot of stuff that keeps us safer when we're pulling from an entire form. However, as we're only really using the object to set/check the edit token and get a contribution_tracking row, I figured it was not completely insane. Also, that check for 'true' up there, is actually looking for the string 'true'... and getVal returns the whole value, not just isSomething. I promise it works. :) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
