User "GICodeWarrior" posted a comment on MediaWiki.r100413.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100413#c25357
Commit summary:
Added a forgotten file
Followup r100345 and Internationalization/#129
Comment:
Could be tweaked a bit if you want.
This: jQuery( document ).ready( function( $ ) {
could be: jQuery( function( $ ) {
This:
var $buttons = $( ".mw-translate-messagereviewbutton" );
$buttons.each( function() {
var $b = $(this);
$b.click( function() {
Could be:
$( '.mw-translate-messagereviewbutton' ).click( function() {
var $b = $(this);
You should also handle HTTP related errors. (Unless it is safe to trust a
global handler somewhere else I am unaware of.)
$.post( ... ).fail(function() {
// Message the user in a meaningful way that there was a HTTP/network error.
});
See: http://api.jquery.com/jQuery.post/#jqxhr-object
and http://api.jquery.com/jQuery.ajax/#jqXHR
Hope that helps :-)
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
