User "Awjrichards" posted a comment on MediaWiki.r101576. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101576#c25363 Commit summary:
begining to handle transaction errors for globalcollect - this might be all wrong! Comment: We just chatted IRL and it turns out it's actually written almost correctly. The $referrer is actually the URL the user is being returned to and $params gets tacked on to the query string. This makes more sense then :p Please make that clear in a comment. Also, we should make sure that $referrer already has a query string, otherwise doing: <pre> $returnto = htmlspecialchars_decode( $referrer ) . '&' . $params; </pre> will have icky results. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
