On 3 November 2011 18:29, Brion Vibber <[email protected]> wrote: > On Thu, Nov 3, 2011 at 9:20 AM, John <[email protected]> wrote: > >> I submitted https://bugzilla.wikimedia.org/show_bug.cgi?id=31469 when 1.18 >> was rolled out. Is there any way that we can get this issue fixed for the >> 1.18 tarball? >> > > TL;DR summary: messages expanded during addTrackingCategory() get run > through parser function/variable expansion with an unexpected title during > links-rebuild jobs. This interferes with a clever set of > meta-categorization being hacked into some of the tracking categories by > including parser functions in the message. > > > It needs investigation as to what the actual cause of the problem is, and I > can't guess just from looking at what we've seen so far whether the fix > will be a one line tweak or a big refactor. > > So I ain't gonna guarantee anything, but it'd be a nice thing to fix if we > can figure it out! > > If somebody's familiar with MessageCache internals and how messages get > parsed etc and can offhand say where to look, that'd likely be very helpful.
That's one scary piece of code (rivaling parser in my view). There has been changes semi-recently which title is used for parsing. I think it currently sometimes takes title from appropriate context, sometimes it just fallbacks to wgTitle or even dummy title. -Niklas -- Niklas Laxström _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
