User "Brion VIBBER" changed the status of MediaWiki.r100126. Old Status: ok New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r100126. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100126#c25435 Commit summary: Add documentation Fix some unused variables, commented some others out Comment: <pre> $html = htmlspecialchars( $text ); - $html = $this->parse( $text, true ); + $html = $this->parse( $html, true ); </pre> This looks wrong -- it kinda looks like the first line should be removed instead of this change to the second line; if we're parsing wikitext, we generally don't want to htmlspecialchars() it first. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
