User "Bryan" changed the status of MediaWiki.r101835. Old Status: ok New Status: fixme
User "Bryan" also posted a comment on MediaWiki.r101835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101835#c25440 Commit summary: Force thumb rendering! Since the [[Special:VipsTest]] is used to test the vips scaler, we want to make sure the thumb is actually rendered and not showing an old rendering. Requires MediaWiki Core r101833 Comment: I think you are making wrong assumptions here. We will run SpecialVipsTest while Imagemagick is still the default rendered. So, File::transform will return an Imagemagick thumbnail. This thumbnail does not need to be regenerated, so RENDER_FORCE should not be necessary. Currently you only show the Imagemagick thumbnail. SpecialVipsTest should output both the Imagemagick thumbnail, and the vips thumbnail. The vips thumbnail should be a thumbnail refering to the the stream function of the special page. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
