User "Catrope" posted a comment on MediaWiki.r101844.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101844#c25494
Commit summary:
"and" missing
Comment:
Niklas said "not demonstrably secure" which is not the same thing as "not
secure". Code should be written in such a way that the reviewer can immediately
tell that it's secure ("demonstrably secure"). This code is not written that
way, which requires a review to dig into the code and figure out where the
various variables come from and what the getLatestTransactionRestriction
function can return, and determine if any of those can lead to security issues.
This is bad because it's harder to tell if something is secure. It's still
possible to write secure code this way, it's just hard to review and easy for a
developer to do it wrong or to break security later.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
