User "IAlex" changed the status of MediaWiki.r101464. Old Status: new New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101464 Commit summary: checkbox could not be checked through URL parameter On [[Special:EmailUser]], someone ought to be able to pass the checkboxes names to overrides the default. As an example from bug 31770, the email user page has a checkbox wpCCMe which let the user as for a copy of the email being send. This is a user preference. One change that checkbox state by appending ?wpCCMe=<boolean> ie: Special:EmailUser/Hashar?wpCCMe=0 Special:EmailUser/Hashar?wpCCMe=1 The logic added in r84814 could have allowed checkboxes to be overriden for GET form. Unfortunately, HTMLForm is mostly with the default POST. Hence, when appending the query parameter, we would never honor it! The fix is to still unconditionally look at the value if the form was correctly submitted (ie has wpEditToken) and additionaly whenever there is a checkbox name appearing in the query (wherever it is false or true, hence the use of getVal()). This is a regression in REL1_18. I dont think it deserves a release notes since it is not fixing anything compared to 1.17. Bug fixed: ========== * (bug 31770) Allow URL parameter wpCCMe on Special:EmailUser * (bug 30909) URL parameters for checkboxes in Special:Block no longer work _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
