User "Awjrichards" posted a comment on MediaWiki.r100953. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100953#c25513 Commit summary:
Updated TwoStepAmount form to use ResourceLoader. Using jquery.validation.js. Prepping form for dropdowns and Direct Debit. Comment: <pre> + $this->setPaymentMethod( $this->form_data['payment_method'] ); + $this->setPaymentSubmethod( $this->form_data['payment_submethod'] ); </pre> $this->form_data['whatever'] should now be accessed from the adapter. This is not a blocker, but should be updated. Also, consider taking a look at the HTML class rather than the XML class for generating HTML output. It's more likely to properly sanitize output and is generally easier to write/read. http://svn.wikimedia.org/doc/classHtml.html _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
