User "Khorn (WMF)" posted a comment on MediaWiki.r101956. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101956#c25518 Commit summary:
Added $error_map, getErrorMap(), getErrorMapByCodeAndTranslate(), getTransactionErrors(). Modified getTransactionDataLanguage() to pull language from multiple places. Comment: <pre>+ * @todo + * - Can we just get the language from somewhere else to make this simpler? + *</pre> Yes. <br> getData_Raw( 'language' ); <br>It's public and everything. Two more things here: All this logic is not only combing through successful transaction results for data we have locally, it's doing it for specific transactions in the common gateway adapter. Please keep everything that is gateway-specific (and certainly everything that is transaction-specific) as far away from the common adapter as you possibly can, at all times. <br><br> Also: Once again, 'errors' is still a misnomer in the gateway objects. It should be RESPONSE codes. So, there's no guarantee they will be empty if the transaction was a success. This should all be renamed appropriately. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
