User "Aaron Schulz" posted a comment on MediaWiki.r97495.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97495#c25521
Commit summary:

Converted patrol log to the new system

Comment:

getPerformer() gets called on each LogEventsListRow, which is a similar 
performance regression as what happened with BlockList recently.
<pre>
        public function getPerformer() {
                $userId = (int) $this->row->log_user;
                if ( $userId !== 0 ) {
                        return User::newFromRow( $this->row );
                } else {
                        $userText = $this->row->log_user_text;
                        return User::newFromName( $userText, false );
                }
        }
</pre>

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to