User "Jpostlethwaite" posted a comment on MediaWiki.r102087. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102087#c25522 Commit summary:
Added new information to payment_submethods. Required keys are now designated in for each direct debit product. These are now added with the method: addKeysToTransactionForSubmethod(). Although the fields are required, if they did not exist in staging or in the form as elements, they will not be attached to the XML request sent to GlobalCollect - this is not a bug, it is a feature! Several more fields for direct debit were added to $this->var_map. Comment: As you can see the some of the lines of code are really long. I am hesitant to make changes in this right now. We should see how the arrays take shape as any more data as added. I have some ideas about this, but now is not the time for testing. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
