User "Aaron Schulz" changed the status of MediaWiki.r96545. Old Status: ok New Status: fixme
User "Aaron Schulz" also posted a comment on MediaWiki.r96545. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96545#c25526 Commit summary: Use LogFormatter to format log entries. * Anonymous users now display correctly This paves the way for new LogFormatters than enable proper i18n. Each log type must be converted individually. Comment: getPerformer() gets called on each LogEventsListRow, which is a similar performance regression as what happened with BlockList recently. <pre> public function getPerformer() { $userId = (int) $this->row->log_user; if ( $userId !== 0 ) { return User::newFromRow( $this->row ); } else { $userText = $this->row->log_user_text; return User::newFromName( $userText, false ); } } </pre> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
