User "Nikerabbit" changed the status of MediaWiki.r102060. Old Status: deferred New Status: fixme
User "Nikerabbit" also posted a comment on MediaWiki.r102060. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102060#c25536 Commit summary: bugfix (#autoedit not able to update a field with a +) Comment: I understand html_entitity_decode, but I don't understand why you have htmlentities() here. Xml::input already escapes the value for you, so now you get one form of double escaping. In addition using htmlentities without defining charset break all non-ascii letters. Urldecode() is also used for summary, maybe others too - they should be changed too. I would suggest using just Sanitizer::decodeCharReferences for the input on necessary places. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
