User "Khorn (WMF)" posted a comment on MediaWiki.r102086. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102086#c25550 Commit summary:
Added method: addKeyToTransaction(). This is a helper to modify the transaction INSERT_ORDERWITHPAYMENT. Comment: This function should either live in the globalcollect adapter, or be abstracted in such a way that any gateway can use it (probably way easier to just put it in the GC-specific gateweay - that way you don't have to consider non-xml transactions, or searching the xml tree structure to find the correct node). Please do not put gateway-specific code in the gateway-agnostic GatewayAdapter class. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
