User "Khorn (WMF)" posted a comment on MediaWiki.r101960. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101960#c25558 Commit summary:
Removing usage of $result and $data from the view. Enabling bank transfer, real time bank transfer and direct debit. See r101956. Comment: Moving the $data back inside the controller, is extremely helpful. One question, though: Why did you remove $result? This is exactly the sort of place you'd want to use the return values of do_transaction, unless you've already moved all the logic for handling everything about that result to the inside of the adapter, and for some things, that might be more trouble than it's worth. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
