User "Khorn (WMF)" changed the status of MediaWiki.r101960. Old Status: new New Status: fixme
User "Khorn (WMF)" also posted a comment on MediaWiki.r101960. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101960#c25564 Commit summary: Removing usage of $result and $data from the view. Enabling bank transfer, real time bank transfer and direct debit. See r101956. Comment: <pre>+ elseif ( $payment_method == 'dd' ) { + + $this->adapter->do_transaction( 'DO_BANKVALIDATION' ); + + if ( $this->adapter->getTransactionStatus() ) { + + $this->adapter->do_transaction( 'INSERT_ORDERWITHPAYMENT' ); + }</pre> getTransactionStatus only tells us if we have gotten a rational response form the remote server: It does not parse the result at all. Currently, this will submit the direct debit request if the remote server exists and your DO_BANKVALIDATION request is not completely malformed. <br><br>According to the documentation, you need to be pulling a node called "CHECKRESULT", parsing the value there, and acting on that result. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
