User "Khorn (WMF)" changed the status of MediaWiki.r102084. Old Status: new New Status: fixme
User "Khorn (WMF)" also posted a comment on MediaWiki.r102084. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102084#c25572 Commit summary: Changed getText() to getVal() where a null value was specified. Several of these just had the null second parameter removed because it was not necessary to be null. Comment: All of the lines that didn't get changed to getVal, but had their default of 'null' removed, need to either be changed back, or changed to getVal like the others. getText's second parameter is not null: It is a blank string (See /includes/WebRequest.php). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
