User "Nikerabbit" posted a comment on MediaWiki.r102132.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102132#c25586
Commit summary:

SocialProfile: as per Markus' in-depth review:
*move hook registration to the top of the file
*documentation updates
*i18n
*moved inline CSS to the CSS file
*removed some duplicate code
*return an array when we're supposed to return one instead of returning a string

Comment:

For updateeditcounts-updating and updateeditcounts-updated I suggest 
$wgOut->addWikiMsg( 'name', 'param1' ); The other messages should be escaped in 
way or another.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to