User "Nikerabbit" posted a comment on MediaWiki.r102177. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102177#c25598 Commit summary:
SocialProfile: as per Markus' in-depth review: *var -> private *prevent empty IN() clauses in SQL by checking that the variable is *not* empty before using it in the SQL query *move global variable declaration out of the foreach loop in setSystemGiftsRec() Comment: If you only want to check if array is empty, use count() instead. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
