User "Dantman" posted a comment on MediaWiki.r99369. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99369#c25657 Commit summary:
Fix up makeLinkItem and makeLink: - Don't explicitly name attributes to use (fixes bug on language_links in 1.18) - Allow makeLink to accept options specifying how to wrap links and text Comment: This was something for the BaseTemplate skin stuff I introduced in in 1.18. The addition of link-fallback, link-class, and text-wrapper is somewhat minor and not used anywhere by default but it's something I really should have accounted for in the original BaseTemplate::makeLink code that I didn't at the time, and later realized when I attempted to use my own BaseTemplate code inside of a client project that needed it in order for the design to work. It's a minor feature but without it the BaseTemplate stuff isn't really complete. Also in here is a fix for a regression caused by the BaseTemplate code. The language_urls had a title on them pre-1.18 but because I had this code white-listing attributes the title="" was being stripped out of stuff in the language box in skins updated to use makeListItem. On a suggestion from another user I switched the code to blacklist stuff actually used rather than only allow a limited subset of attributes. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
