User "Catrope" posted a comment on MediaWiki.r102375.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102375#c25675
Commit summary:
Use the fonts for the variant script for wikis with multiple scripts(sr,zh
etc). Use wgUserVariant
variable to find out the variant language code.
Font selection is based on uservariant, contentlanguage , and userlanguage.
i18n card #117
Comment:
NOOOOO!
You MUST NOT use a for .. in loop to loop over an array. If you're looping over
an array (e.g. <code>var arr = ['foo', 'bar', 'baz'];</code>) you MUST use for
i = 0 ... and if you're looping over an object (e.g. <code>var obj = { 'foo':
'bar', 'baz': 'quux' };</code>) you MUST use for .. in. Using for..in to loop
over an array will seem to work but is prone to very strange bugs when people
extend <code>Array.prototype</code>.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
