User "Krinkle" posted a comment on MediaWiki.r99307.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99307#c25714
Commit summary:
Add !important to the tablesorter indicator.
Otherwise it is too easy to do <th style="background:red"> and kill the entire
indicator.
Fixes bug 31196 and follow up to r98665
Comment:
Still, there is no need for <code>!important</code> here.
I believe there is no excuse of <code>!important</code> in core stylesheets at
any time (except maybe for vendor/IE-hacks). There are ways around it, and in
this case the work-around is already in place. The selector here is more
specific than the selector that the local wikis have.
Example:
<pre>
-- mw core
table.jquery-tablesorter th.headerSort {
color: green;
}
-- local wiki
table.sortable th {
color: red;
}
-- html
<table class="sortable jquery-tablesorter">
<tr>
<th> This text is green </th>
</tr>
</table>
</pre>
Please remove the !important.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
