User "Nikerabbit" changed the status of MediaWiki.r102484. Old Status: deferred New Status: fixme
User "Nikerabbit" also posted a comment on MediaWiki.r102484. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102484#c25746 Commit summary: Fix for r102368 - apparently, the is_null() check was necessary; replaced the checks with calls to empty() Comment: No you are back in to the original situation where "00" doesn't work. I would suggest trim( $foo ) !== '', or if ''true'' should not be interpreted as 1, add is_string() check too. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
