User "Catrope" changed the status of MediaWiki.r102426. Old Status: new New Status: fixme
User "Catrope" also posted a comment on MediaWiki.r102426. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102426#c25761 Commit summary: Committing a non-working untested copy of the first go at this extension, mostly so we have a checkpoint to look at/review, and also to make sure commit access works. Comment: So did you copy the extension on your local system, modify it, then commit it? That's the worst thing you could've done with regards to preserving history. You should use svn copy to make sure the history is preserved, and you shouldn't copy and modify in the same revision. I outlined this in an e-mail I sent to Fabrice and Yoni on October 25th: <blockquote> Also, please use svn copy to fork the extension, and svn rename to rename the files in your copy; that way history is preserved. Also, do not copy/rename and change a file in the same commit, doing so makes review harder. All this means you'll probably need 3 commits to fork the extension: one for a verbatim copy, one to rename all the files, and one to update the contents of the files to match the changed extension name, file names, prefixes, etc. </blockquote> Please revert this revision and execute the clone properly. If you have trouble doing these things, I'm willing to do it for you. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
