Thanks for the detailed explanation, Helder and Roan!

Daniel

On Wed, Nov 9, 2011 at 12:26 PM, Roan Kattouw <[email protected]> wrote:
> On Wed, Nov 9, 2011 at 11:36 AM, Helder <[email protected]> wrote:
>> Hi!
>>
>> This may be unrelated to the problem you describe, but when I access
>> https://als.wikipedia.org/wiki/Special:RecentChanges?debug=1&uselang=en
>> I get the following errors on Firefox 7.0.1:
>> ----
>> Error: $("body") is null
>> Source:
>> https://bits.wikimedia.org/w/extensions-1.18/Vector/modules/ext.vector.collapsibleTabs.js
>> Line: 5
>>    var rtl = $( 'body' ).is( '.rtl' );
>> ----
>> Error: linkFA_enabled is not defined
>> Source:
>> https://bits.wikimedia.org/als.wikipedia.org/load.php?debug=true&lang=en&modules=site&only=scripts&skin=vector&*
>> Line: 141
>>    if (!linkFA_enabled) return;
>> ----
>>
>> Besides, if I try to close the Fundraising banner, on a random page such as
>> https://als.wikipedia.org/wiki/City_Life?debug=1&uselang=en
>> I get
>> ----
>> Error: $("#centralNotice") is null
>> Source:
>> https://als.wikipedia.org/w/index.php?title=Spezial:BannerController&cache=/cn.js&303-4
>> Line: 20
>> ----
>>
>> I believe these bugs are caused by the first line on
>> https://als.wikipedia.org/wiki/MediaWiki:Common.js?uselang=en
>> i.e.:
>>    function $(ID) {return document.getElementById(ID);}
>> because $ is a default alias for jQuery, which is used by various scripts.
> Yes, that's what causing it. Although, really, MediaWiki code should
> always be aliasing $ to the global jQuery object, which
> BannerController and collapsibleTabs clearly aren't doing.
>
> Roan
>
> _______________________________________________
> Wikitech-l mailing list
> [email protected]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>

_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Reply via email to