User "Khorn (WMF)" posted a comment on MediaWiki.r102480. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102480#c25838 Commit summary:
More updates in the name of language cleanup. Now sets defaults for language and premium_language in normalization, rather that during the actual initial data pull from a form. Comment: Nope. Here's the argument: getText uses getVal, does some texty-things to whatever comes back (like dealing with line breaks), and then defaults to an empty string unless you tell it otherwise. getVal is, according to the documentation, supposed to be used with scalars. In other words, the difference goes beyond the default return value. Remember, we're not always pulling from forms with identical fields, here. We _need_ to be able to tell the difference between an explicitly empty string being passed in, and the field not existing in the post. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
